Skip to content

Revert "Temporarily disable the DAV plugin until clients work" #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 30, 2025
Merged

Revert "Temporarily disable the DAV plugin until clients work" #1018

merged 5 commits into from
Jan 30, 2025

Conversation

@GretaD
Copy link
Collaborator

@GretaD GretaD commented Nov 27, 2024 •
edited
Loading

Reverts #510

ref: #990

🧑‍🏭 Todo:

  • make sure this works with all clients

@GretaD GretaD self-assigned this Nov 27, 2024
@GretaD
Copy link
Collaborator Author

GretaD commented Nov 27, 2024 •
edited
Loading

tobi deployed it on the terms LTD, we will test it soon

@max-nextcloud max-nextcloud force-pushed the revert-510-bugfix/noid/disable-sabre-plugin branch 5 times, most recently from 2f3b489 to 81dc9f2 Compare December 4, 2024 12:35
@mgallien mgallien mentioned this pull request Jan 29, 2025
Closed
@mgallien
Copy link

mgallien commented Jan 29, 2025

desktop files client is only checking the HTTP return code currently
meaning that as long as the return code is 403, the PR will not cause any visible impact for current releases
we still need to detect the more specific exception that is added by this PR nextcloud/desktop#7805

@nickvergessen nickvergessen removed their request for review January 29, 2025 15:40
@GretaD GretaD force-pushed the revert-510-bugfix/noid/disable-sabre-plugin branch from 09c14ec to c63b0af Compare January 30, 2025 09:58
GretaD and others added 5 commits January 30, 2025 11:06
@GretaD
Revert "Temporarily disable the DAV plugin until clients work"
1da3bfb 
Signed-off-by: Max <[email protected]>
Signed-off-by: greta <[email protected]>
@max-nextcloud @GretaD
fix(psalm): use \OCP\Server
058a57a 
replace `\OC::$server` with public \OCP\Server::get()

Signed-off-by: Max <[email protected]>
Signed-off-by: greta <[email protected]>
@max-nextcloud @GretaD
fix(psalm): require-dev sabre/dav
1c15d96 
Signed-off-by: Max <[email protected]>
Signed-off-by: greta <[email protected]>
@max-nextcloud @GretaD
enh(dav): TermsNotSignedException
16edb06 
Signed-off-by: Max <[email protected]>
Signed-off-by: greta <[email protected]>
@max-nextcloud @GretaD
enh(dav): send base url as message in 403 response
53f22a5 
Signed-off-by: Max <[email protected]>
Signed-off-by: greta <[email protected]>
@GretaD GretaD force-pushed the revert-510-bugfix/noid/disable-sabre-plugin branch from c63b0af to 53f22a5 Compare January 30, 2025 10:06
@GretaD GretaD merged commit c88d675 into master Jan 30, 2025
29 of 32 checks passed
@GretaD GretaD deleted the revert-510-bugfix/noid/disable-sabre-plugin branch January 30, 2025 11:07
@GretaD
Copy link
Collaborator Author

GretaD commented Jan 30, 2025

/backport to stable27

@backportbot backportbot bot mentioned this pull request Jan 30, 2025
Merged
2 tasks
@max-nextcloud max-nextcloud mentioned this pull request Feb 3, 2025
Closed
@juliusknorr juliusknorr mentioned this pull request Feb 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

Assignees

@GretaD GretaD

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GretaD @mgallien @max-nextcloud