Skip to content

Conversation

@GretaD
Copy link
Collaborator

@GretaD GretaD commented Jan 17, 2025

No description provided.

@GretaD GretaD marked this pull request as ready for review January 21, 2025 12:39
@GretaD GretaD requested a review from provokateurin January 21, 2025 12:39
@GretaD GretaD self-assigned this Jan 21, 2025
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The route is still there (

'name' => 'Signing#signTermsPublic',
) and the frontend also still uses it (
url = '/apps/terms_of_service/sign_public'
), so you can't just remove it.

@GretaD GretaD changed the title fix: unused logic fix: unused parameter Jan 21, 2025
@GretaD
Copy link
Collaborator Author

GretaD commented Jan 21, 2025

The route is still there (

You're right, i misunderstood the reporting. It was reported as unused parameter and not method.

@GretaD GretaD requested a review from provokateurin January 21, 2025 12:55
@provokateurin
Copy link
Member

OpenAPI also needs to be updated.

@GretaD
Copy link
Collaborator Author

GretaD commented Jan 21, 2025

OpenAPI also needs to be updated.

that doesnt block me to merge this one, right?

@provokateurin
Copy link
Member

It should, but the job is not marked as required. You can simply fix it by running composer openapi and amending the changes.

Signed-off-by: greta <[email protected]>
@GretaD GretaD merged commit 42df440 into master Jan 22, 2025
29 checks passed
@GretaD GretaD deleted the fix/unused-logic branch January 22, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants