Merged
Conversation
provokateurin
requested changes
Jan 21, 2025
Member
provokateurin
left a comment
There was a problem hiding this comment.
The route is still there (
terms_of_service/appinfo/routes.php
Line 35 in e3cbd4e
terms_of_service/src/UserApp.vue
Line 122 in e3cbd4e
Collaborator
Author
You're right, i misunderstood the reporting. It was reported as unused parameter and not method. |
provokateurin
approved these changes
Jan 21, 2025
Member
|
OpenAPI also needs to be updated. |
Collaborator
Author
that doesnt block me to merge this one, right? |
Member
|
It should, but the job is not marked as required. You can simply fix it by running |
44ec24a to
f422cf6
Compare
Signed-off-by: greta <[email protected]>
f422cf6 to
0b906c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.