-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deleting rich workspaces readme.md #4782
Conversation
3 failed and 1 flaky tests on run #12061 βοΈ
Details:
Β cypress/e2e/attachments.spec.js β’ 3 failed testsΒ cypress/e2e/files.spec.js β’ 1 flaky test
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
5af1cd1
to
c689613
Compare
Code looks good. Cypress test would be nice to avoid regressions in the future. |
c689613
to
ee7d1ba
Compare
@max-nextcloud @juliushaertl I found that cypress tests for workspace was set to skip here |
@luka-nextcloud I agree that we certainly should re-enalble the Cypress tests for rich workspaces. Seems like skipping them was meant as temporary in db7aa50 anyway. Maybe you can take a look at fixing the Cypress tests? |
I think a first step towards this would be running the current master branch locally and checking how rich workspaces work there. Maybe some of the functionality is still missing. |
@mejo- @max-nextcloud I'd suggest to open a separate ticket for the cypress work, what do you think? |
@luka-nextcloud I'm fine with this. Could you open the issue? |
Here's a separate ticket: #4829 |
Signed-off-by: Luka Trovic <[email protected]>
ee7d1ba
to
ddca577
Compare
π Summary
πΌοΈ Screenshots
π§ TODO
π Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)