Fix 403 on close #4824
Merged
Fix 403 on close #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
reviewed
Sep 26, 2023
max-nextcloud
force-pushed
the
fix/403-on-close
branch
from
e8de906
to
0f5545b
Compare
|
/backport to stable27 |
|
/backport to stable26 |
Signed-off-by: Max <[email protected]>
y.js will send a last awareness update when closing the websocket. Try to get this out before closing the sync service connection. Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/403-on-close
branch
from
0f5545b
to
d899714
Compare
juliusknorr
approved these changes
Oct 30, 2023
mejo-
approved these changes
Oct 30, 2023
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport d17bc9a,d89971462e6233fa0d24be39bfa903c79f6cb6d2 to stable27 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)