-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Enable gapcursor, allows to put cursor between images #5095
Conversation
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Fixes: #3427 Signed-off-by: Jonas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Thanks for looking into this!
This might also address some aspects of #3111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
(I need those nice test images as well 😁 🦖)
Unfortunately not yet. We might be able to configure the mentions node to allow gapcursor before it, but out of the box it's not possible. |
I love them 🦕 They're from https://prosemirror.net/examples/dino/ |
/backport to stable28 |
📝 Summary
Enable gapcursor extension and remove workaround to add newlines between images when uploading more than one.
🖼️ Screenshots
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)