-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): contrast for active menubar buttons #5098
Conversation
Thinking more about the dropdown, maybe it is already fine like it is as the primary trigger button already indicates the state? |
I'd be happy to merge this as is as a start and then discuss how to continue. |
Changing text/src/components/Menu/ActionEntry.scss Line 47 in e1afbfe
fill: var(--color-primary-element-text) should most likely fix it
|
e1afbfe
to
7946478
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the screenshots but didnt test.
Maybe we should loop in Frank because it is kind of a drastic design change again?
Let's check with @jancborchardt then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do this the same in Office already, so yep while it is very present, accessibility- and consistency-wise this is a good solution. :)
7946478
to
9541eb4
Compare
Cypress failures seem related |
9541eb4
to
95212f0
Compare
95212f0
to
6c1ec51
Compare
Removed the padding on mobile views (<768 according to texts definition). Bildschirmaufzeichnung.vom.21.12.2023.08.11.03.webm |
/backport to stable28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks a lot!
Cypress tests are still failing and the failure seems to be related. |
Dropdown menus (headings and callouts) are still low contrast. Signed-off-by: Max <[email protected]>
* Use default (white) text in active buttons in light mode. * Add a 2px margin between menubar buttons to have a bit of spacing when two buttons are active next to each other. Signed-off-by: Max <[email protected]>
Also fix the computation of the number of slots available Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
2a5c47f
to
66d4d8e
Compare
📝 Summary
🖼️ Screenshots
Dropdown menus (headings and callouts) are still low contrast:
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)