-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check and apply markdown for smart picker output #5106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions for detecting the markdown syntax (I know we can't cover everything there), but otherwise this seems fine and works well 👍
Maybe I'm missing something here, but why do we have to detect markdown manually at all, instead of just doing |
Hm, unsure about that. It might be fine to just always pass it to markdown it indeed. |
I have tried this way and faced an issue. The markdown-it render function always adds some newline character to content. So, If input value is an url, the inserted content will be a normal string instead of a link (enclose it in an angle brackets). |
b15266c
to
b7d3de0
Compare
Signed-off-by: Luka Trovic <[email protected]>
b7d3de0
to
cb4ad16
Compare
📝 Summary
Always consider smart picker output as markdown.
🚧 TODO
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)