Multiline tables with block node content

[mejo-]

📝 Summary

• Allow any block node type as children of table cells
• Use markdown-it-multimd-table to parse markdown tables
• Implement new markdown serializer for whole tables to support multi-line cells
• Allow headerless tables
• Support cell alignment in serializer, but only serialize cells that contain just text, paragraph and image nodes. All other nodes can be problematic and result in broken markdown that cannot be parsed again.
• Resolves: Pasting an image into a table splits it #4047
• Resolves: Inserting Images into Table Cells #4687
• Resolves: Text rich editor column smart picker content breaks tables #7582

🖼️ Screenshots

🏡 Editor	Serialized Markdown

🚧 TODO

• Allow block+ as content for tableCell. For some reason, allowing blockquotes results in all cell rows being serialized to markdown as blockquote. I didn't find out yet why this is the case
• 2x return used to create/jump to next row. This is currently broken. Do we want it back?
• Optionally remove our custom newline special-handling with <br> in table cells
• Reset sessions on app update
• Custom paste handler breaks pasting into code blocks. We need to replace it with a paste handler that prevents nested tables and allows everything else
• Prevent nested tables via filterTransaction (as suggested here

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits
• Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

[codecov]

Codecov Report

❌ Patch coverage is 92.53731% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.70%. Comparing base (dadf315) to head (c619227).

Files with missing lines	Patch %	Lines
src/nodes/Table/TableCell.js	33.33%	2 Missing ⚠️
src/nodes/Table/TableHeadRow.js	0.00%	2 Missing ⚠️
src/nodes/Table/TableHeader.js	0.00%	2 Missing ⚠️
src/nodes/Table/TableRow.js	0.00%	2 Missing ⚠️
src/nodes/Table/markdown.ts	98.19%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7523      +/-   ##
==========================================
+ Coverage   52.91%   59.70%   +6.78%     
==========================================
  Files         497      497              
  Lines       42943    38164    -4779     
  Branches     1125     1124       -1     
==========================================
+ Hits        22724    22786      +62     
+ Misses      20111    15271    -4840     
+ Partials      108      107       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[max-nextcloud]

@mejo- Did you figure out what prevents nesting a table in a table right now?

[mejo-]

@mejo- Did you figure out what prevents nesting a table in a table right now?

Not exactly, but I guess it's rather a broken can() (or however this command to check whether the feature is possible at current cursor position is called). Pasting a table into a table cell works currently. That's why I added the two TODO points to make it technically impossible to add nested tables (via filterTransaction) and to filter out nested tables in handlePaste().

[Aveyron-RetD]

Will this fix as well, rich previews added with the smart picker ?
#7582

[janbaum]

2x return used to create/jump to next row. This is currently broken. Do we want it back?

Just wanted to say that I would love this being broken 🫠