enh/y indexeddb #7621
Open
enh/y indexeddb #7621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7621 +/- ##
==========================================
- Coverage 45.96% 45.86% -0.10%
==========================================
Files 141 141
Lines 3964 3977 +13
Branches 747 750 +3
==========================================
+ Hits 1822 1824 +2
- Misses 1838 1847 +9
- Partials 304 306 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
from
15aff59 to
9b4afdb
Compare
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
from
9b4afdb to
d43a2a7
Compare
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
from
d43a2a7 to
f52166a
Compare
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
7 times, most recently
from
6637691 to
e746625
Compare
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
5 times, most recently
from
6d4c06b to
1ade042
Compare
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
4 times, most recently
from
853ca71 to
0a18ad3
Compare
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Merged
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
For now text is sometimes duplicated Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Keep the baseVersionEtag and the editing session around in case people who are offline connect again later. Signed-off-by: Max <[email protected]>
... and use it to check if the server is still on the same session. Signed-off-by: Max <[email protected]>
When reopening a document that was edited offline it will also be considered dirty now. Autosave will not kick in yet... As no steps are pushed. But when closing the file it will be saved. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
…Step Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
If no changes have been made offline clear the indexedDb cache and reload Editor.vue to load the latest editing session from the server. Signed-off-by: Max <[email protected]>
Use a setter function that remains functional even if the component has already been destroyed and reactivity does not work anymore. Signed-off-by: Max <[email protected]>
yjs and editor update logging can be very verbose. Uncomment it but keep it disabled by default. Can be enabled by setting the corresponding key in OCA.Text - i.e. `window.OCA.Text.logWebSocketPolyfill = true` in the browser console. Signed-off-by: Max <[email protected]>
It was still enabled as we mistyped the `disableBc` option. We cannot use it right now as the y-websocket room name does not include the base version etag. Therefore different tabs may be in different sessions and would risk syncing never the less. Observed this when reloading the editor on an outdated session: * Cleaning up the old yjs document took a while in the beforeDestroy callback. * The new document was already created. * The new y-websocket provider issued a sync step 1 via browser broadcast. * The old y-websocket provider responded and send its full state. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Otherwise the old session would get mixed with the new content when people come back with old state in indexed-db. ( Run playwright/e2e/indexed-db.spec.ts for an example. ) Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
enh/y-indexeddb
branch
from
0a18ad3 to
d1d57d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
base_version_etagas custom property to IndexedDBbaseVersionEtagas part of create requestbaseVersionEtag.