-
Notifications
You must be signed in to change notification settings - Fork 110
fix(files): Disable suggestions bar output for not rich workspace #7875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(files): Disable suggestions bar output for not rich workspace #7875
Conversation
Signed-off-by: julia.kirschenheuter <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7875 +/- ##
==========================================
- Coverage 47.10% 47.06% -0.04%
==========================================
Files 141 141
Lines 3883 3886 +3
Branches 733 733
==========================================
Hits 1829 1829
- Misses 1760 1763 +3
Partials 294 294 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mejo-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier is unhappy, apart from that code looks good.
|
@marcoambrosini I know we removed the placeholder text, but now nothing is indicating to the user that they can click in there and type something if it is empty and not in focus. |
|
@juliusknorr what about re-introducing the placeholder? Why was it taken out? If accessibility is the concern, I think we could solve it by having an action that focuses the |
It was removed in #6855 when the smart picker button was added to the side. I also think we should bring it back, not only in empty rich workspace documents, but in general. |
|
|
@max-nextcloud to address those points:
|
|
Sounds good to me. I wonder if it might be easier to use the approach of the suggestion bar of checking for an empty editor for the placeholder as well. |
|
https://tiptap.dev/docs/editor/extensions/functionality/placeholder Does behave as I would expect to only render if the document is fully empty by using css rules as in the example |
📝 Summary
🖼️ Screenshots