Skip to content

Conversation

@JuliaKirschenheuter
Copy link
Contributor

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
image image

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.06%. Comparing base (3e1b521) to head (a01a711).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7875      +/-   ##
==========================================
- Coverage   47.10%   47.06%   -0.04%     
==========================================
  Files         141      141              
  Lines        3883     3886       +3     
  Branches      733      733              
==========================================
  Hits         1829     1829              
- Misses       1760     1763       +3     
  Partials      294      294              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier is unhappy, apart from that code looks good.

@juliusknorr
Copy link
Member

@marcoambrosini I know we removed the placeholder text, but now nothing is indicating to the user that they can click in there and type something if it is empty and not in focus.

@marcoambrosini
Copy link
Member

marcoambrosini commented Oct 31, 2025

@juliusknorr what about re-introducing the placeholder? Why was it taken out? If accessibility is the concern, I think we could solve it by having an action that focuses the textarea within the new menu. It could read: "Add folder description"

@mejo-
Copy link
Member

mejo- commented Nov 1, 2025

@juliusknorr what about re-introducing the placeholder? Why was it taken out? If accessibility is the concern, I think we could solve it by having an action that focuses the textarea within the new menu. It could read: "Add folder description"

It was removed in #6855 when the smart picker button was added to the side. I also think we should bring it back, not only in empty rich workspace documents, but in general.

@max-nextcloud
Copy link
Collaborator

Why was it taken out?

  • It seemed redundant to write... "Type / to add" when there's a plus button right next to it.
  • Not everyone can mention people (I think it's not possible on public shares). So the "@ to mention" part would have needed to become context dependent.
  • The placeholder we used did not just show on an empty document but also in empty lines, which seemed broken to me as placeholders usually go away when something is typed into the textfield and do not show again on new emtpy lines.

@marcoambrosini
Copy link
Member

@max-nextcloud to address those points:

  1. I think It's still nice a nice invitation and it inform users about the existence of the keyboard shortcut
  2. We can skip the @ mention part
  3. This is just a bug that can be fixed

@max-nextcloud
Copy link
Collaborator

Sounds good to me. I wonder if it might be easier to use the approach of the suggestion bar of checking for an empty editor for the placeholder as well.
Previously we used the tiptap placeholder extension if i remember correctly. Fixing that seems more involved.

@juliusknorr
Copy link
Member

https://tiptap.dev/docs/editor/extensions/functionality/placeholder Does behave as I would expect to only render if the document is fully empty by using css rules as in the example

 /* Placeholder (at the top) */
  p.is-editor-empty:first-child::before {
    color: var(--gray-4);
    content: attr(data-placeholder);
    float: left;
    height: 0;
    pointer-events: none;
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove suggestions buttons from text preview

6 participants