-
Notifications
You must be signed in to change notification settings - Fork 110
WIP: Add LaTex Support #7957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WIP: Add LaTex Support #7957
Conversation
|
I wanted to see if it would push the expected files - not ready for review yet |
Signed-off-by: James Manuel <[email protected]> feat(:tada:): Make clean branch to avoid pollution from build files in project feat(:wrench:): Update package-lock to be inline with main feat(:wrench:): Update package-lock to be inline with main
9eaa0ee to
533af02
Compare
|
@max-nextcloud Sorry about the confusion, hopefully this PR is better to check. It only has one commit as I took the files from the other branch. |
|
|
||
| Nextcloud Text is the default text editor since Nextcloud 17. To start editing just open an existing markdown or plaintext file or create a new one. | ||
|
|
||
| ### Mathematical formulas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far we do not really have much end user documentation. I'd say we could keep it in here for now still. We probably want this to go to docs.nextcloud.com but just the math section might not be that useful.
@max-nextcloud @mejo- Something we could discuss further as you were thinking about enhancing documentation for collectives, but there may be some overlap with what we could make use of for text itself.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, I left one inline comment and there are two CI checks that need some more work to pass.
When testing the modal seems to have an issue with not taking up the full height of the textarea, but I'm unsure if that is a component issue or could be addressed here as well. Would be fine to track as a follow up for polishing:
|
Also cc @marcoambrosini for a design review |
Signed-off-by: James Manuel <[email protected]>
Signed-off-by: James Manuel <[email protected]>
…thing and not removed Signed-off-by: James Manuel <[email protected]>
0d8e038 to
8d381b5
Compare
Signed-off-by: James Manuel <[email protected]>

📝 Summary
This PR adds LaTeX math support to the text app.
it uses:
$…$$$…$$Code:
Tests:
It adds some tests covering the features added, and issues I encountered while adding the feature
Limitations:
The existing modal doesn’t appear to be resizable - therefore here is set to largest
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)