fix: Update room data in storage when adding a file#170
Merged
juliusknorr merged 1 commit intomainfrom Sep 18, 2024
Merged
Conversation
Signed-off-by: Julius Knorr <[email protected]>
hweihwang
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noticed by @szaimen when using the redis storage strategy files were not persisted in the room data so they were missing on the saved file and not available to other users.
This fixes it by updating the room data after adding a file. With the LRU strategy this is not an issue as the object is just in memory so using addFile was enough to propagate it to the room state.