Skip to content

Comments

Update README.md#192

Closed
amitshuklabag wants to merge 1 commit intonextcloud:mainfrom
amitshuklabag:patch-1
Closed

Update README.md#192
amitshuklabag wants to merge 1 commit intonextcloud:mainfrom
amitshuklabag:patch-1

Conversation

@amitshuklabag
Copy link

@amitshuklabag amitshuklabag commented Sep 26, 2024

It should be /socket.io/ for reverse proxy in nginx.

I have tried in my app and having an issue with /whiteboard/ but it works fine with /socket.io/

or update the code to hit the URL /whiteboard instead of /socket.io

It should be /socket.io/ for reverse proxy in nginx.

Signed-off-by: Amit Shukla <53058928+amitshuklabag@users.noreply.github.com>
@nfebe nfebe requested a review from juliusknorr September 26, 2024 14:28
@juliusknorr
Copy link
Member

Using /whiteboard works fine on my test setup here. What URL did you configure in the whiteboard app on the NExtcloud side? The full https://example.com/whiteboard ?

@juliusknorr juliusknorr added documentation Improvements or additions to documentation needs info labels Oct 8, 2024
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs clarification

@EricMeallier
Copy link
Contributor

EricMeallier commented Oct 24, 2024

this change will only change how you want to name your endpoint to access whiteboard application.
After all, i push a new PR to fix reverse nginx configuration a side

=> PR to be closed

@juliusknorr
Copy link
Member

Thanks again for your contribution. I think this has been meanwhile addressed in #242 so I'll close this one. Feel free to still reply if you have to add further comments on the previous questions or new configuration adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation feedback-requested needs info

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants