Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whiteboard exapp #226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Whiteboard exapp #226

wants to merge 1 commit into from

Conversation

hweihwang
Copy link
Contributor

Steps to run:

occ app_api:app:register whiteboard_websocket --info-xml=./apps/whiteboard/websocket_server/appinfo/info.xml

@hweihwang hweihwang marked this pull request as ready for review October 15, 2024 11:58
@hweihwang hweihwang marked this pull request as draft October 15, 2024 11:58
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early comments and questions, but looks promising :)

src/collaboration/Portal.ts Outdated Show resolved Hide resolved
websocket_server/ApiService.js Outdated Show resolved Hide resolved
websocket_server/Dockerfile Show resolved Hide resolved
websocket_server/package.json Show resolved Hide resolved
Signed-off-by: Hoang Pham <[email protected]>
@hweihwang hweihwang marked this pull request as ready for review October 22, 2024 09:54
@hweihwang hweihwang linked an issue Oct 24, 2024 that may be closed by this pull request
3 tasks
- SPDX-License-Identifier: AGPL-3.0-or-later
-->
<info>
<id>whiteboard_websocket</id>
Copy link
Member

@juliusknorr juliusknorr Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleksandr-nc Is it possible to have an ext app shipped as part of an existing regular PHP app? So if the ext app ecosystem is installed it will just run the docker container in addition to the existing logic?

Would be quite nice if we could just do one release to the app store that works with and without ext app support

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment there is no such functionality, but if there is a request for implementing this, and Daphne approve this, Andrey or I can add this feature.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess https://github.com/nextcloud/app_api is the right place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate ext app for node backend
3 participants