use NcReferenceList in whiteboard #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Jul 18, 2024
grnd-alt
force-pushed
the
feat/custom-web-embed
branch
from
01c7672
to
2932ae5
Compare
|
Forgot to paste from our call notes:
|
grnd-alt
force-pushed
the
feat/custom-web-embed
branch
from
2a53186
to
7e3183c
Compare
grnd-alt
commented
Jul 19, 2024
|
|
||
| // embeddables get updated a lot by the excalidraw library when collaboration is active | ||
| // we need to filter out useless updates to not rerender every millisecond. | ||
| // current master of the excalidraw library probably fixes this issue but it's not available in excalidraw@latest (0.17.6) |
There was a problem hiding this comment.
checking if the objects are DeepEqual is a workaround. Not entirely certain, but I do think if we could use the lib like excalidraw.com does here: https://github.com/excalidraw/excalidraw/blob/master/excalidraw-app/collab/Collab.tsx#L751 we would not need this workaround. However I couldn't figure out how to use the master version of excalidraws library in our build process.
There was a problem hiding this comment.
Sounds good, being able to build from master or another branch/a fork there is something that could certainly be useful, but we can check that separately
grnd-alt
force-pushed
the
feat/custom-web-embed
branch
from
cf97925
to
4f1832e
Compare
Signed-off-by: grnd-alt <[email protected]>
stop infinite rerending when collaborating Signed-off-by: grnd-alt <[email protected]>
grnd-alt
force-pushed
the
feat/custom-web-embed
branch
from
4f1832e
to
ff860c2
Compare
Signed-off-by: grnd-alt <[email protected]>
grnd-alt
force-pushed
the
feat/custom-web-embed
branch
from
ff860c2
to
b0c97fe
Compare
juliusknorr
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #9