Move task hashing logic to separate class #6572
Open
+406
−292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
jorgee
reviewed
Nov 17, 2025
| } | ||
|
|
||
|
|
||
| def 'should get bin files in the script command' () { |
Contributor
There was a problem hiding this comment.
Why this test has been removed. It doesn't seem to be related to TaskHasher.
Member
Author
There was a problem hiding this comment.
Both of these tests were moved to the TaskHasherTest and refactored. This is because the bin scripts and task directive vars are only used to calculate the task hash.
I believe the only other place these methods are used is in the LinObserver, and that's only to preserve the hash components in the TaskRun lineage record
|
|
||
| } | ||
|
|
||
| def 'should get task directive vars' () { |
Contributor
There was a problem hiding this comment.
Same as before, it doesn't seem to be related with task hasher.
pditommaso
requested changes
Nov 20, 2025
Member
Author
|
The motivation is in the PR description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the task hashing logic from
TaskProcessorto a separate classTaskHasher