Fix invalid cache write when cacheable split operation fails #6588
+110
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Ben Sherman <[email protected]>
bentsherman
force-pushed
the
6494-fix-splitfasta-complete
branch
from
5d2bc42 to
38aea8f
Compare
pditommaso
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6494
This PR fixes an issue with cacheable split operations such as splitFasta / splitFastq / splitText with
file: true. In this case the operation saves a cache file that can be used on subsequent runs to reuse the chunks.However, this cache file was always being written, even when the split operation fails (e.g. by exhausting the JVM heap), causing subsequent runs to have a false cache hit instead of re-computing the chunks.
This PR fixes the issue by moving the
markComplete()call so that it's only called after the split operation completes successfully.