Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plot co2e and energy in one plot with two axis #87

Merged
merged 5 commits into from
Feb 22, 2024
Merged

plot co2e and energy in one plot with two axis #87

merged 5 commits into from
Feb 22, 2024

Conversation

mirpedrol
Copy link
Collaborator

@mirpedrol mirpedrol commented Jan 31, 2024 •
edited
Loading

image

@mirpedrol mirpedrol marked this pull request as ready for review February 1, 2024 15:55
@mirpedrol mirpedrol requested a review from skrakau February 1, 2024 15:55
skrakau
skrakau reviewed Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@skrakau skrakau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @mirpedrol !

Did something change regarding displaying the values? I was wondering why the median is displayed as 16.4 not and not 16.40. Wasn't this like this before?

plugins/nf-co2footprint/src/resources/CO2FootprintReportTemplate.html Outdated Show resolved Hide resolved
plugins/nf-co2footprint/src/resources/assets/CO2FootprintReportTemplate.js Outdated Show resolved Hide resolved
plugins/nf-co2footprint/src/resources/CO2FootprintReportTemplate.html Outdated Show resolved Hide resolved
@skrakau
Copy link
Collaborator

skrakau commented Feb 20, 2024

Sorry for the late review @mirpedrol !

@mirpedrol
Copy link
Collaborator Author

Did something change regarding displaying the values? I was wondering why the median is displayed as 16.4 not and not 16.40. Wasn't this like this before?

This is due to a new way I found to determine which number of decimals to use: https://github.com/nextflow-io/nf-co2footprint/pull/87/files#diff-c42fa18c056e4a0988d45f4a58d2604ec610ff4e979f175cdf8243ee3f235890R79-R86
now, instead of using the maximum value of the whole dataset to determine the number of decimal positions, we do it case by case, values of >= 4 will have only 1 position

skrakau
skrakau approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@skrakau skrakau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skrakau skrakau merged commit 172c7bf into nextflow-io:master Feb 22, 2024
2 checks passed
@mirpedrol mirpedrol mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrakau skrakau skrakau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirpedrol @skrakau