-
Notifications
You must be signed in to change notification settings - Fork 254
Polish and enhance Hello nf-core training materials #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pinin4fjords
wants to merge
109
commits into
master
Choose a base branch
from
minor_nfcore_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 82 commits
Commits
Show all changes
109 commits
Select commit
Hold shift + click to select a range
3398a4f
Correct memory in test profile
pinin4fjords ef869bb
Reframe test profile section to avoid implying param inference
pinin4fjords 73663f5
Update Nextflow version to 25.04.3 in nf-core materials
pinin4fjords 2046e07
Update nf-core/demo version to 1.0.2
pinin4fjords a140ea4
Updated nf-core/demo output
pinin4fjords 7ea59bd
mend
pinin4fjords f9cb647
update demo pipeline contents
pinin4fjords 7519429
Refine subworkflow coverage
pinin4fjords 879a0f2
correct tree level
pinin4fjords 848ada1
Correct another tree level, params schema coverage
pinin4fjords 4a43382
Update input schema content
pinin4fjords e64de7e
Fix priority issues in nf-core Part 1
pinin4fjords aba50d7
Improve style consistency in nf-core Part 1
pinin4fjords 8b6378a
Add content enhancements to nf-core Part 1
pinin4fjords 789c802
Fix issues in nf-core Part 2
pinin4fjords 3b7dd22
fix workflow listing
pinin4fjords c0de862
Update first run output
pinin4fjords 8d33f7c
Clarify section 3 transition in nf-core Part 2
pinin4fjords c8250d2
Add a highlight
pinin4fjords dbe6611
Reorder section 3.3 to show proper version channel pattern
pinin4fjords 65e7de7
fix line num
pinin4fjords 754f28e
Fix highlights, indents
pinin4fjords 2d665af
More highlight fixes
pinin4fjords 3bd54c5
Fix indents
pinin4fjords 1d9dec3
Add missing highlights
pinin4fjords 8597694
Clarify .view line removal in section 3.3
pinin4fjords 6950066
Remove redundancy at section 4 start
pinin4fjords 8f61263
Update solution
pinin4fjords 2172ddd
Merge branch 'master' into minor_nfcore_fixes
pinin4fjords 521618c
Fix linting errors in core-hello-part2 solution files
pinin4fjords 6887f13
prettier
pinin4fjords 3e4ff9e
Correct attribution of pipeline_info contents in section 4.5
pinin4fjords 675ff55
Clarify nf-core module naming conventions
pinin4fjords 5ca0877
Add info output
pinin4fjords b0bb38b
Update some outputs
pinin4fjords 3738414
Fix cat content
pinin4fjords 80d8d4e
update some outputs
pinin4fjords b93e362
Fix highlight
pinin4fjords abd223b
Update part 3 solution
pinin4fjords 5ed5250
Remove legacy collectGreetings module from part 3
pinin4fjords a4ed3ff
Improve learning flow with contextual transitions
pinin4fjords b033936
Reframe Part 4 as 'Make an nf-core module'
pinin4fjords 6896d72
Highlight additional nf-core conventions in template
pinin4fjords f05fa10
Clarify working within core-hello pipeline context
pinin4fjords 782fdc6
Minor changes to nf-core part 4
pinin4fjords f4c06d5
Clarify ext.args usage and flexibility
pinin4fjords da5c6a4
Elevate and clarify centralized publishDir explanation
pinin4fjords ba7585a
tweak
pinin4fjords 9567756
Add subtle Babylon 5 reference with kosh character
pinin4fjords f0a2dff
Enrich nf-core modules create section with environment/container details
pinin4fjords 9abb837
Use --empty-template flag for cleaner module creation example
pinin4fjords 4599597
Update module template to match actual --empty-template output
pinin4fjords fecc859
Add reference to nf-test side quest for testing
pinin4fjords 0cd2ae1
Fix remaining file path links to use backticks
pinin4fjords 1e30024
Clarify distinction between channel inputs and ext.args
pinin4fjords 07eaae8
Fix highlight
pinin4fjords 28d55a3
Fix highlight
pinin4fjords 9903a25
Fix up part 4 solution
pinin4fjords c717558
Try some linting fixes
pinin4fjords 5c02a4b
Fix linting errors in nf-core solution files
pinin4fjords 66201a7
prettier
pinin4fjords 7723bab
Fix nested list indentation in input validation docs
pinin4fjords 4b64c3f
Fix list rendering in input validation docs
pinin4fjords add3cbf
Remove redundant sentence from validation section
pinin4fjords b0f1ffc
Clarify nf-schema as standalone plugin
pinin4fjords 2f886f0
Update schema docs to use interactive builder tool
pinin4fjords 0c481f8
Fix image links
pinin4fjords e243af6
Fix image paths in input validation docs
pinin4fjords 3de3c4e
Fix validation configuration approach
pinin4fjords 35d3206
Improve schema_input.json section with before/after
pinin4fjords ef9cfd3
Replace file link with backticked string
pinin4fjords 2da8036
Reorganize validation configuration section
pinin4fjords cdebcd2
Polish validation docs for consistency and clarity
pinin4fjords 06a246d
Add context about Hello Nextflow workflow
pinin4fjords 0083c0e
Add course overview to orientation
pinin4fjords a194442
Add summary page to Hello nf-core course
pinin4fjords cae5504
Update Part 5 ending to point to summary page
pinin4fjords 31b2ac4
Fix solutions
pinin4fjords 8d37b37
Some linting fixes
pinin4fjords f3cdbea
Fix linting errors in core-hello-part5 solution
pinin4fjords 16d2f3f
Fix remaining linting issues in core-hello-part5 solution
pinin4fjords 43d222d
Strip nf-core side quest in favour of 'hello nf-core'
pinin4fjords a35789d
Fix workflow description to match actual behavior
pinin4fjords 49b6945
Try some folding directory listings
pinin4fjords bcf14eb
Replace step labels and bold text with numbered headings in hello_nf-…
pinin4fjords dd73bdf
Prettier
pinin4fjords 4f06fe9
Address Geraldine's editorial comments on Hello nf-core
pinin4fjords 439f480
Remove remaining em-dashes from Hello nf-core
pinin4fjords 21936bf
Address editorial comments from PR review
pinin4fjords c973b08
Move publishDir configuration details to note box
pinin4fjords 659e075
Restore backticks
pinin4fjords e5301ca
Improve publishDir configuration explanation
pinin4fjords 4b4517d
Minor editorial improvements to module creation section
pinin4fjords f8b57c9
Clarify module template customization requirements
pinin4fjords 38e3550
Restructure validation intro and reduce overconfident claims
pinin4fjords 35a281d
Clarify monochromeLogs parameter description
pinin4fjords 31273b7
Clarify input data validation scope and monochromeLogs
pinin4fjords 35b51fb
Make takeaway bullet more explicit about publishDir
pinin4fjords 43f75d9
Prioritize visual output verification over command inspection
pinin4fjords 1476787
Change section heading to avoid overloaded 'template' term
pinin4fjords bb96228
prettier
pinin4fjords 464fc0c
Correct a highlight
pinin4fjords e0a79c0
Merge branch 'master' into minor_nfcore_fixes
adamrtalbot c0e1f41
Move "What you'll learn" content to index page
vdauwera 0a4d306
Improvements to the Orientation page
vdauwera e92b430
minor tweaks
vdauwera 740b5d0
Reworked Part 1 (run demo) for clarity and flow
vdauwera 850fe48
Add green start button
vdauwera 1fb065c
Completed updates to Part 2
vdauwera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.