Draft
Conversation
MythicalFish
force-pushed
the
refresh-token-2
branch
2 times, most recently
from
26a858c to
02f3b6a
Compare
tcrespog
reviewed
Jul 29, 2025
Comment on lines
+9
to
+11
| // TODO: Security implications of rolling up this secret into the built extension | ||
| export const AUTH0_CLIENT_SECRET = | ||
| "tZ3N8vHuvpLQlzdGEhel4Vz5DeluNNyTtid-2jFBdDiXmIGNbX9yhjDmQ2Pg6VT-"; |
There was a problem hiding this comment.
My thoughts:
- It should be okay as long as we bear in mind that the client is considered a public client (contrary to a confidential client, which is capable of holding configuration time secrets), so the client should not be shared for purposes other than the VSCode plugin: the client is still bound by other measures (authentication by user-agent to authorization server, redirect URIs, ...).
- Given that it is public, the client might as well have no authentication because the secret serves no real purpose at the end of the day (configurable through Auth0 dashboard).
- For increased security in these cases, I've heard of PKCE , which might be worth looking into.
There was a problem hiding this comment.
Providing a client secret is not needed when the app is defined as public. Can you try to make it work without this parameter?
As @tcrespog said, PKCE is used to mitigate the risks of now being able to manage a secret key. It is enabled by default.
| reject(new Error("No token")); | ||
| return; | ||
| } | ||
| if (!state) { |
There was a problem hiding this comment.
For increased security, the state could be compared with the one created originally. They must match to make sure that the state wasn't altered in the process.
MythicalFish
force-pushed
the
refresh-token-2
branch
from
02f3b6a to
82a7951
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://seqera.atlassian.net/browse/SH-739
Using PR deployment of platform & dev Auth0 application for now