ESLint: use type-safe equality operators #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous check of != null would fail on non-null falsey values. In practice, I don't think Element.querySelector can return any falsey values other than null. Nevertheless, it's good to be explicit that we only care about null, i.e. no matches are found.¹ ¹ https://developer.mozilla.org/en-US/docs/Web/API/Element/querySelector#return_value
Using == / != is a source of bugs. Rule doc page: https://eslint.org/docs/latest/rules/eqeqeq
nextstrain-bot
temporarily deployed
to
auspice-victorlin-eslin-xkyeb5
16 tasks
jameshadfield
approved these changes
Oct 21, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1373 (comment)
Checklist
If making user-facing changes, add a message in CHANGELOG.md summarizing the changes in this PR(to be done by a Nextstrain team member) Create preview PRs on downstream repositories.