Skip to content

Conversation

@victorlin
Copy link
Member

@victorlin victorlin commented Oct 24, 2025

Note

Based on #89, nextstrain/augur#1918

Description of proposed changes

This removes workflow-specific config modifications and takes advantage of a Snakemake feature.

Related issue(s)

Checklist

  • Details

    Tested `nextstrain run` locally
    $ nextstrain run --augur=/Users/vlin/repos/nextstrain/augur . phylogenetic tmp
    
    localrule filter:
        input: results/run_config.yaml, data/sequences.fasta, data/metadata.tsv, /nextstrain/pathogen/phylogenetic/defaults/include_strains_genome.txt, /nextstrain/pathogen/phylogenetic/defaults/dropped_strains.txt
    
    Validating schema of 'results/run_config.yaml'...
    24156 strains were dropped during filtering
            3 were dropped because they were in /nextstrain/pathogen/phylogenetic/defaults/dropped_strains.txt
            4 were dropped because they were earlier than 1950.0 or missing a date
            23510 were dropped because they were shorter than the minimum length of 5000bp when only counting standard nucleotide characters A, C, G, or T (case-insensitive)
            150 were dropped during grouping due to ambiguous year information
            6 were added back because they were in /nextstrain/pathogen/phylogenetic/defaults/include_strains_genome.txt
            495 were dropped because of subsampling criteria
    689 strains passed all filters
  • Checks pass

  • Update changelog

  • Pre-merge: drop e751070

  • Pre-merge: update changelog to replace TBD

victorlin and others added 3 commits October 29, 2025 15:13
… instead of doing this in the workflow upfront.
This takes advantage of the Snakemake feature that detects input file
changes to re-run jobs.
@victorlin victorlin force-pushed the victorlin/custom-config-merge branch from 3980377 to e78aadc Compare October 29, 2025 22:17
@victorlin victorlin force-pushed the victorlin/augur-subsample-resolves-filepaths branch from e751070 to 8c07397 Compare October 29, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants