Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest: thread Slack notifications #36

Open
joverlee521 opened this issue Jun 7, 2022 · 1 comment
Open

ingest: thread Slack notifications #36

joverlee521 opened this issue Jun 7, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@joverlee521
Copy link
Contributor

Context

We get multiple Slack notifications per ingest run, so it would be cleaner to have these notifications threaded.

Possible Solution

  • See ncov workflow for example of how this can be done with PersistentDict.

  • Maybe another way we can go about this is edit the global Snakemake config to store the thread_ts? (Just a thought, haven't really tested if this is possible...)

@joverlee521 joverlee521 added the enhancement New feature or request label Jun 7, 2022
@jameshadfield
Copy link
Member

Maybe another way we can go about this is edit the global Snakemake config to store the thread_ts

This dosn't work (unfortunately) because each rule gets a copy of the config, which prevents this message-passing approach. PersistentDict was the only solution I could get to work (short of writing to a small file), but it's tricky to debug as when running locally a new snakemake run will still have access to the previous dict which can get confusing (it works for automated runs as they're in a new worker / environment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants