Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check types in CI #1070

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check types in CI #1070

wants to merge 1 commit into from

Conversation

victorlin
Copy link
Member

Description of proposed changes

Previously, the only enforcement of TypeScript was through ESLint rules from @typescript-eslint.

Checklist

Previously, the only enforcement of TypeScript was through ESLint rules
from @typescript-eslint.
@@ -17,6 +17,7 @@
"lint": "npm run lint:server",
"lint:server": "DEBUG=eslint:cli-engine npx eslint --max-warnings=0 --ext .js,.jsx .",
"lint:static-site": "cd static-site && DEBUG=eslint:cli-engine npx eslint --max-warnings=0 --ext .js,.jsx,.ts,.tsx .",
"type-check": "cd static-site && tsc",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@genehack could you look into this type error? It's related to changes from #1032

Error: components/nav/nav-logo.tsx(25,12): error TS2322: Type '{ src: string; }' is not assignable to type 'string | StaticImport'.
  Type '{ src: string; }' is missing the following properties from type 'StaticImageData': height, width

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, will try to look at that tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants