Update people component #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsibley
approved these changes
May 15, 2024
The difference in usage required a lot of intermediate variables and most of the code was unshared. Splitting gets rid of the intermediates and unnecessary props (e.g. teamPage, comma).
victorlin
force-pushed
the
victorlin/update-people-component
branch
from
13d44a9
to
4047edc
Compare
|
@tsibley thanks for noting that! I didn't realize there was already a member without link. I've updated the commit message from a8e591e to 4047edc. The color difference is because (1) links here are set to a specific color and (2) the non-links don't have any color set via CSS. It seems like both our browsers default to pure black |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
No functional changes – prepping for #860
Checklist