Closed
Conversation
Reverts "Set container styles in one place" (32229ad) and moves the additional styling to globals.css
This has no effect because there is only one child element.
Use the media queries from Bootstrap's various tiers for more predictable responsive design behavior. Two changes were made: 1. Convert max-width queries to min-width queries 2. For queries on widths that were not at Bootstrap's breakpoints, round to the closest Bootstrap breakpoint.
Member
Author
|
Closing this since we are moving away from styled-components: #963 (comment) Thinking through if each commit should be considered in the future:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Small fixes around styling. I might incorporate more from #963 (comment) into this PR.
Related issue(s)
#963
Checklist