Skip to content

Add the consensus_bcftools subworkflow prototype #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 26, 2025

Conversation

sgsutcliffe
Copy link

We, the Montreal team, mocked up a subworkflow for the issue 127, we added the additional missing modules that we needed from viralrecon.

We took one local module from viralrecon (RENAME_FASTA_HEADER) and converted one nf-core module to localBEDTOOLS_GENOMECOV to use a new param.genomecov_threshold with a default as 10 (as was in the line here)

bedtools genomecov -bga -ibam $BAM | awk '$4 < 10' > low_coverage_sites.bed

Note: BEDTOOLS_GENOMECOV is pending a nf-core invite request from a team-member.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a resource label : label 'process_single'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you change the channel names to match the template usually used by nf-core e.g. ch_query instead of query_channel.

Please remove commented out gff and nextclade_db inputs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@avantonder avantonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great. Please can you address the changes and I will merge the PR once this is done and bedtools genomecov has been added.

@sgsutcliffe
Copy link
Author

Thanks for the comments! The bedtools genomecov tool is in PR#141 and the comments have been addressed.

@avantonder avantonder merged commit 758ac60 into nf-core:dev Mar 26, 2025
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants