-
Notifications
You must be signed in to change notification settings - Fork 51
Add the consensus_bcftools subworkflow prototype #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a resource label : label 'process_single'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you change the channel names to match the template usually used by nf-core e.g. ch_query
instead of query_channel
.
Please remove commented out gff
and nextclade_db
inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great. Please can you address the changes and I will merge the PR once this is done and bedtools genomecov
has been added.
Thanks for the comments! The |
We, the Montreal team, mocked up a subworkflow for the issue 127, we added the additional missing modules that we needed from viralrecon.
We took one local module from viralrecon (
RENAME_FASTA_HEADER
) and converted one nf-core module to localBEDTOOLS_GENOMECOV
to use a newparam.genomecov_threshold
with a default as 10 (as was in the line here)Note:
BEDTOOLS_GENOMECOV
is pending a nf-core invite request from a team-member.