-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dsl1 2.5.0 #1021
Dsl1 2.5.0 #1021
Conversation
2.4.7 Patch
still need:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs adding of mapDamage to README list of tools but otherwise LGTM
Co-authored-by: James A. Fellows Yates <[email protected]>
Citation is there already given it is already used for damage rescaling! Line 249 in 631f18e
|
Added mapDamage to Default Pipeline Steps in README. Standardised tool name to |
Will wait for mapdamage module to be added to multiqc, then should be ok to merge |
Should add a big fat warning top of the readme sayi g maximum NDC aversion of 22.10.6 |
Regarding the Bowtie read groups, the suggested edits would also need to be propagated to the bwa job.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mapdamage stuff looks good, lets wait for feedback on the RG
TODO: |
Co-authored-by: James A. Fellows Yates <[email protected]>
I think that's everything! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming old linting working and tests pass
@ltcrod Please have a look at the RG information for the mappers. Let me know if anything would be better implemented differently. |
Linting works with nf-core v1.14. only failures are about template matching. |
Closes #1020.
Closes #1017.
Clsoes #1031.
PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).