Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dsl1 2.5.0 #1021

Merged
merged 28 commits into from
Nov 1, 2023
Merged

Dsl1 2.5.0 #1021

merged 28 commits into from
Nov 1, 2023

Conversation

TCLamnidis
Copy link
Collaborator

@TCLamnidis TCLamnidis commented Aug 18, 2023

  • Added option to use MapDamage instead of DamageProfiler for damage estimation. Also added options to downsample to a specified number of reads for damage calculation with mapDamage.
  • Fixed a niche error causing file name collisons.

Closes #1020.
Closes #1017.
Clsoes #1031.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@TCLamnidis
Copy link
Collaborator Author

TCLamnidis commented Aug 18, 2023

still need:

@TCLamnidis TCLamnidis requested a review from jfy133 August 22, 2023 13:19
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs adding of mapDamage to README list of tools but otherwise LGTM

docs/output.md Outdated Show resolved Hide resolved
main.nf Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
Co-authored-by: James A. Fellows Yates <[email protected]>
@TCLamnidis
Copy link
Collaborator Author

TCLamnidis commented Aug 23, 2023

Citation is there already given it is already used for damage rescaling!

eager/README.md

Line 249 in 631f18e

* **mapDamage2** Jónsson, H., et al 2013. mapDamage2.0: fast approximate Bayesian estimates of ancient DNA damage parameters. Bioinformatics , 29(13), 1682–1684. [https://doi.org/10.1093/bioinformatics/btt193](https://doi.org/10.1093/bioinformatics/btt193)

@TCLamnidis
Copy link
Collaborator Author

Added mapDamage to Default Pipeline Steps in README. Standardised tool name to mapDamage across all docs (as the name is in the GH repository of the tool)

@TCLamnidis
Copy link
Collaborator Author

Will wait for mapdamage module to be added to multiqc, then should be ok to merge

@jfy133
Copy link
Member

jfy133 commented Oct 11, 2023

Should add a big fat warning top of the readme sayi g maximum NDC aversion of 22.10.6

@TCLamnidis
Copy link
Collaborator Author

Regarding the Bowtie read groups, the suggested edits would also need to be propagated to the bwa job.
Specifically:

  • Changing the RG-ID to the sample name from the library name, and
  • adding a separate field to the RG with the library ID

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapdamage stuff looks good, lets wait for feedback on the RG

docs/output.md Outdated Show resolved Hide resolved
@TCLamnidis
Copy link
Collaborator Author

TODO:
MultiQC does not pick up the mapdamage outputs locally, even though they are correctly published within the work directory and the module is activated. Have to check what is wrong.

@TCLamnidis
Copy link
Collaborator Author

I think that's everything!

@TCLamnidis TCLamnidis requested a review from jfy133 October 27, 2023 09:32
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming old linting working and tests pass

@TCLamnidis TCLamnidis requested a review from ltcrod October 27, 2023 11:20
@TCLamnidis
Copy link
Collaborator Author

@ltcrod Please have a look at the RG information for the mappers. Let me know if anything would be better implemented differently.

@TCLamnidis
Copy link
Collaborator Author

Linting works with nf-core v1.14. only failures are about template matching.

@TCLamnidis TCLamnidis merged commit e3b22ea into patch Nov 1, 2023
6 of 8 checks passed
@TCLamnidis TCLamnidis deleted the dsl1-2.5.0 branch November 1, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DSL1: Input file name collision when merging two already merged BAMs in additional_library_merge step.
3 participants