Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 2.5.1 #1052

Merged
merged 15 commits into from
Feb 21, 2024
Merged

Patch 2.5.1 #1052

merged 15 commits into from
Feb 21, 2024

Conversation

TCLamnidis
Copy link
Collaborator

@TCLamnidis TCLamnidis commented Feb 16, 2024

Patch release 2.5.1 - Bopfingen

Closes #1036
Closes #1037
Closes #1047
Closes #1048
Closes #1049
Closes #1051

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@TCLamnidis TCLamnidis added this to the 2.5.1 - Bopfingen (patch) milestone Feb 16, 2024
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @TCLamnidis,

It looks like this pull-request is has been made against the nf-core/eager master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/eager dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

Copy link

Markdown linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install markdownlint-cli
  • Fix the markdown errors
    • Automatically: markdownlint . --config .github/markdownlint.yml --fix
    • Manually resolve anything left from markdownlint . --config .github/markdownlint.yml

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@TCLamnidis
Copy link
Collaborator Author

All markdown linting fails for various reasons, but linting is fine locally (except for logos being outdated).

@TCLamnidis TCLamnidis mentioned this pull request Feb 16, 2024
11 tasks
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
assets/multiqc_config.yaml Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
Co-authored-by: James A. Fellows Yates <[email protected]>
@TCLamnidis
Copy link
Collaborator Author

I will update the date in the changelog and make the release tomorrow

@TCLamnidis TCLamnidis deleted the patch-2.5.1 branch February 21, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment