-
Notifications
You must be signed in to change notification settings - Fork 84
Add nf-test #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add nf-test #1063
Conversation
|
Variable outputDamage profiler:
Not sure which output idr (
Qualimap:
MultiQC:
fastp:
fastqc:
Misc comments
|
Existing tests to make sure we account for with new configs:
|
…roblem with collection/name not working
…Dir (but not working - no md5swum?!)
Ok, just need to sort the lists and then it should work (md5sums are the same but just seem to be out of order) |
nf-core/eager#1063 Co-authored-by: jfy133 <[email protected]> Co-authored-by: nvnieuwk <[email protected]>
nf-core/eager#1063 Co-authored-by: jfy133 <[email protected]> Co-authored-by: nvnieuwk <[email protected]>
nf-core/eager#1063 Co-authored-by: jfy133 <[email protected]> Co-authored-by: nvnieuwk <[email protected]>
So, technically it is all there. I keep having trouble excluding I will keep trying today, but @jfy133 you will probably need to take this over the finish line. |
it's not just HTML, it seems to be the netire
That isn't working |
Still haven't worked out what is going on, but I've added some debugging prints which should help us where the issue is coming in, the output of
To me it looks like the two lists are being picked up correctly. My suspicioun is the use of So function works - but we are using it badly by allowing directories to be in the list that is passed to nf-test |
To check: HTML files that @TCLamnidis said was missing |
Possible remaining things:
Based on this I'm assuming @TCLamnidis checked that we get variable header AND names, therefore I will just add them to the 'unstable' and check for names system |
I think this is working now! I aded the missing bam/flagstats as just checking for names |
Can confirm this snapshot worked. All files are present. I removed some comments and debug outputs. I think this is ready |
I updated the nf-test to the new test profile setup. The results from authentication still contain some unstable files, but I think that is caused by instability in the underlying BAM files. Not sure how we can fix that, short of filtering the original FastQs and input BAMs to not include any unique reads starting at the same position... The following files had were unstable in my last local run:
|
… test profile
Initial set up, testing command
nf-test test --tag test --profile test,docker
PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).