-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dsl2 new test configs #1121
base: dev
Are you sure you want to change the base?
Dsl2 new test configs #1121
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking VERY very good @jbv2 ! Very close, and almost 1:1 ratio with the plan in the issue - good job!
Just a few comments
…into dsl2-new_test_configs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a short review for the ploidy declaration for modules.config
Co-authored-by: Ian Light-Maka <[email protected]>
Co-authored-by: Ian Light-Maka <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
…into dsl2-new_test_configs
No description provided.