-
Notifications
You must be signed in to change notification settings - Fork 83
Dsl2 new test configs #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dsl2 new test configs #1121
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking VERY very good @jbv2 ! Very close, and almost 1:1 ratio with the plan in the issue - good job!
Just a few comments
…into dsl2-new_test_configs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a short review for the ploidy declaration for modules.config
Co-authored-by: Ian Light-Maka <[email protected]>
Parameters removed from
|
…into dsl2-new_test_configs
…into dsl2-new_test_configs
This reverts commit ed59eb4.
I'm just checking that |
I confirm |
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.2.0. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny change, otherwise LGTM
To close: #1103