-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sylph/profile module #7118
Add sylph/profile module #7118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested to be a bit more specific about the created csv :)
@sofstam , do you need a hand to get this finished off? |
@SPPearce Was on holidays, looking at the comments now :) |
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
@famosab The tests are passing now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, was just wondering why you removed the { assert process.success },
statements from the nf-test. I would add it back in and then approve this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small things still, but otherwise fine by me
The options should also be --
format, but -t
doesn't have one it seems.
Co-authored-by: Mahesh Binzer-Panchal <[email protected]>
Co-authored-by: Mahesh Binzer-Panchal <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Mahesh Binzer-Panchal <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Mahesh Binzer-Panchal <[email protected]>
@mashehu , do you want the change to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@SPPearce I will wait with merging then. |
PR checklist
Moves the local module
sylph/profile
to nf-core modules. Closes nf-core/seqinspector#65Removes unnecessary pattern from
sylph/sketch
meta file.versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda