Skip to content

Commit 96b54b9

Browse files
authored
Merge pull request #244 from nf-core/nf-core-template-merge-3.2.1
Important! Template update for nf-core/tools v3.2.1
2 parents d9b8aea + ba1eb0d commit 96b54b9

File tree

5 files changed

+21
-41
lines changed

5 files changed

+21
-41
lines changed

.github/workflows/awsfulltest.yml

Lines changed: 10 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -4,57 +4,36 @@ name: nf-core AWS full size tests
44
# It runs the -profile 'test_full' on AWS batch
55

66
on:
7-
pull_request:
8-
branches:
9-
- main
10-
- master
117
workflow_dispatch:
128
pull_request_review:
139
types: [submitted]
10+
release:
11+
types: [published]
1412

1513
jobs:
1614
run-platform:
1715
name: Run AWS full tests
18-
# run only if the PR is approved by at least 2 reviewers and against the master branch or manually triggered
19-
if: github.repository == 'nf-core/pangenome' && github.event.review.state == 'approved' && github.event.pull_request.base.ref == 'master' || github.event_name == 'workflow_dispatch'
16+
# run only if the PR is approved by at least 2 reviewers and against the master/main branch or manually triggered
17+
if: github.repository == 'nf-core/pangenome' && github.event.review.state == 'approved' && (github.event.pull_request.base.ref == 'master' || github.event.pull_request.base.ref == 'main') || github.event_name == 'workflow_dispatch'
2018
runs-on: ubuntu-latest
2119
steps:
22-
- name: Get PR reviews
23-
uses: octokit/[email protected]
24-
if: github.event_name != 'workflow_dispatch'
25-
id: check_approvals
26-
continue-on-error: true
27-
with:
28-
route: GET /repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/reviews?per_page=100
29-
env:
30-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
31-
32-
- name: Check for approvals
33-
if: ${{ failure() && github.event_name != 'workflow_dispatch' }}
34-
run: |
35-
echo "No review approvals found. At least 2 approvals are required to run this action automatically."
36-
exit 1
37-
38-
- name: Check for enough approvals (>=2)
39-
id: test_variables
40-
if: github.event_name != 'workflow_dispatch'
20+
- name: Set revision variable
21+
id: revision
4122
run: |
42-
JSON_RESPONSE='${{ steps.check_approvals.outputs.data }}'
43-
CURRENT_APPROVALS_COUNT=$(echo $JSON_RESPONSE | jq -c '[.[] | select(.state | contains("APPROVED")) ] | length')
44-
test $CURRENT_APPROVALS_COUNT -ge 2 || exit 1 # At least 2 approvals are required
23+
echo "revision=${{ (github.event_name == 'workflow_dispatch' || github.event_name == 'release') && github.sha || 'dev' }}" >> "$GITHUB_OUTPUT"
4524
4625
- name: Launch workflow via Seqera Platform
4726
uses: seqeralabs/action-tower-launch@v2
4827
with:
4928
workspace_id: ${{ secrets.TOWER_WORKSPACE_ID }}
5029
access_token: ${{ secrets.TOWER_ACCESS_TOKEN }}
5130
compute_env: ${{ secrets.TOWER_COMPUTE_ENV }}
52-
revision: ${{ github.sha }}
53-
workdir: s3://${{ secrets.AWS_S3_BUCKET }}/work/pangenome/work-${{ github.sha }}
31+
revision: ${{ steps.revision.outputs.revision }}
32+
workdir: s3://${{ secrets.AWS_S3_BUCKET }}/work/pangenome/work-${{ steps.revision.outputs.revision }}
5433
parameters: |
5534
{
5635
"hook_url": "${{ secrets.MEGATESTS_ALERTS_SLACK_HOOK_URL }}",
57-
"outdir": "s3://${{ secrets.AWS_S3_BUCKET }}/pangenome/results-${{ github.sha }}"
36+
"outdir": "s3://${{ secrets.AWS_S3_BUCKET }}/pangenome/results-${{ steps.revision.outputs.revision }}"
5837
}
5938
profiles: test_full
6039

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ jobs:
8282
- name: Clean up Disk space
8383
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1
8484

85-
- name: Run pipeline with test data
85+
- name: "Run pipeline with test data ${{ matrix.NXF_VER }} | ${{ matrix.test_name }} | ${{ matrix.profile }}"
86+
continue-on-error: ${{ matrix.NXF_VER == 'latest-everything' }}
8687
run: |
8788
nextflow run ${GITHUB_WORKSPACE} -profile test,docker --outdir ./results
8889

.nf-core.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ lint:
33
- assets/nf-core-pangenome_logo_light.png
44
- docs/images/nf-core-pangenome_logo_light.png
55
- docs/images/nf-core-pangenome_logo_dark.png
6-
nf_core_version: 3.2.0
6+
nf_core_version: 3.2.1
77
repository_type: pipeline
88
template:
99
author: Simon Heumos, Michael L Heuer

nextflow.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ manifest {
374374

375375
// Nextflow plugins
376376
plugins {
377-
id 'nf-schema@2.3.0' // Validation of pipeline parameters and creation of an input channel from a sample sheet
377+
id 'nf-schema@2.2.0' // Validation of pipeline parameters and creation of an input channel from a sample sheet
378378
}
379379

380380
validation {

0 commit comments

Comments
 (0)