Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deepvariant subworkflow (issue #614) #651

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

fa2k
Copy link
Contributor

@fa2k fa2k commented Dec 6, 2024

This PR splits DeepVariant into three processes, to optimise the resource usage. (#614)

It doesn't support GPU out of the box, but I have added usage documentation for how to enable it.

PR checklist

  • This comment contains a description of changes (with reason).
  • [na] If you've fixed a bug or added code that should be tested, add tests!
  • [na] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • [na] If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,singularity --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,singularity --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • [na] Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • [na] README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Dec 6, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit e2963a9

+| ✅ 201 tests passed       |+
#| ❔   7 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-raredisease_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-raredisease_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-raredisease_logo_dark.png
  • modules_config - modules_config

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-06 12:32:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant