Adding test data for fusion-report#1566
Open
rachwalp wants to merge 117 commits intonf-core:modulesfrom
Open
Conversation
Add nf-core/atacseq test dataset
Changed test dataset
Add social preview image
Add full test-dataset
add test data to test melt module
Revert README back to correct text
Revert main branch back to original state : without test data in the main branch
Add warning message not to merge to master branch
Update README to mention guidelines
Update CITATION.cff
sateeshperi
reviewed
Mar 27, 2025
| There are three main directories: `generic`, `genomics` and `delete_me`. The first contains generic files, the second contains all datasets for genomics tools while the latter contains temporary datasets that will be deleted as better data gets available. | ||
|
|
||
| ## Adding New Data | ||
|
|
There was a problem hiding this comment.
@jfy133 wanted to check if deleting this part of README was ok ?
There was a problem hiding this comment.
I don't think so. Its outdated but still would not delete
famosab
reviewed
Mar 27, 2025
Comment on lines
-8
to
-13
| If you cannot find suitable test data on this repository, please contact us on the [nf-core Slack `#modules` channel](https://nfcore.slack.com/channels/modules) (you can join with [this invite](https://nf-co.re/join/slack)). The goal is to create a suitable, small test dataset that should be usable with the available test data and if possible be generated with modules available from `nf-core/modules`. If creating that test data is difficult but you want to add the module first, it is also possible to add a small subset to the `delete_me` folder to get your module tests running, and then add proper test data afterwards. This should be discussed on slack. In order to add test data. For a short description of the workflow for adding new data, have a look at [here](docs/ADD_NEW_DATA.md). | ||
|
|
||
| ### delete_me | ||
|
|
||
| The `delete_me` folder does not adhere to a defined structure as data in this folder should be delete as fast as possible, whenever a more suitable dataset is found that can be added to any other folder. | ||
|
|
There was a problem hiding this comment.
Add your file to this README please :)
There was a problem hiding this comment.
I am not sure. These files might need to go into the delete_me folder as they are module specific. (The name is the worst - we are working on renaming it)
Member
|
@rachwalp any reason why you'd want to merge in 117 commits in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/Clinical-Genomics/fusion-report/tree/master/tests/test_data
Adding test data for fusion-report test. This data wasn't in the dataset, it comes from Clinical Genomics repository.