Skip to content

Majority rule ensemble approach#276

Merged
kubranarci merged 11 commits intodevfrom
majority-rule-ensemble-approach
Feb 26, 2026
Merged

Majority rule ensemble approach#276
kubranarci merged 11 commits intodevfrom
majority-rule-ensemble-approach

Conversation

@kubranarci
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/variantbenchmarking branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@kubranarci
Copy link
Contributor Author

@nf-core-bot fix linting

@kubranarci
Copy link
Contributor Author

@georgiakes This PR requires a bit of attention if you dont mind :) I am introducing a new method which is a common approach to generate a proxy truth set where golden set of truth is not available. The idea is to merge input test VCFs, and keep only common (>n) variants - usually majority. Can you check the logic and text and I have added to see if it makes sense?

Plus, I generated a new metromap looking forward for your comments :)

@kubranarci kubranarci linked an issue Feb 25, 2026 that may be closed by this pull request
Copy link
Member

@georgiakes georgiakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hellooo. I think it looks good overall. Some small suggestions :)

kubranarci and others added 4 commits February 26, 2026 08:56
Co-authored-by: Georgia Kesisoglou <[email protected]>
Co-authored-by: Georgia Kesisoglou <[email protected]>
Co-authored-by: Georgia Kesisoglou <[email protected]>
@kubranarci
Copy link
Contributor Author

Hellooo. I think it looks good overall. Some small suggestions :)

thanks for the review :)

@kubranarci kubranarci merged commit 2d64c58 into dev Feb 26, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

concordance analysis for somatic benchmarking

3 participants