Skip to content

Conversation

@Harry-Chen
Copy link
Contributor

No description provided.

rushank-shah and others added 28 commits February 2, 2025 13:38
Enable read & write block for iOS MIFARE Classic, Updated readme
Fix: NFC Handler dead thread issue on Android SDK 35
Signed-off-by: Shengqi Chen <[email protected]>
Signed-off-by: Shengqi Chen <[email protected]>
Signed-off-by: Shengqi Chen <[email protected]>
Signed-off-by: Shengqi Chen <[email protected]>
Signed-off-by: Shengqi Chen <[email protected]>
Copilot finished reviewing on behalf of Harry-Chen November 22, 2025 11:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR releases version 3.6.1 of the flutter_nfc_kit package, focusing on modernizing the web interop layer to support WASM compilation, adding iOS MIFARE block read/write support, improving Android robustness, and updating build tools.

Key Changes

  • Migrated web layer from deprecated dart:js_util to new dart:js_interop APIs for WASM support
  • Added MIFARE Classic/Ultralight read/write block support for iOS platform
  • Enhanced Android NFC handler thread management and fixed null pointer exception in IsoDep API
  • Updated build tools: Gradle 9.2.1, AGP 8.13.0, Kotlin 2.2.21, and lowered minSdkVersion to 24

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
pubspec.yaml Bumped version to 3.6.1, updated dependencies (ndef ^0.4.0, lints ^6.0.0), added web and universal_platform packages
lib/webusb_interop.dart Refactored to use new dart:js_interop APIs, replacing dart:js_util with type-safe JS interop methods
lib/flutter_nfc_kit_web.dart Updated to use package:web instead of dart:html, migrated to new js_interop APIs
lib/flutter_nfc_kit.dart Added universal_platform dependency, added platform check for tagStream to return empty stream on non-Android platforms, added documentation about Samsung devices
ios/flutter_nfc_kit/Sources/flutter_nfc_kit/FlutterNfcKitPlugin.swift Added MIFARE tag support for readBlock (0x30 command) and writeBlock (0xA2 command) operations
example/web/index.html Modernized HTML template, removed service worker script, updated to use flutter_bootstrap_js
example/pubspec.yaml Updated ndef dependency to ^0.4.0
example/pubspec.lock Updated transitive dependencies to reflect new package versions
example/lib/main.dart Fixed formatting in tag info display string (added missing space)
example/android/gradle/wrapper/gradle-wrapper.properties Updated Gradle wrapper to 9.2.1-bin
example/android/gradle.properties Increased JVM memory, updated AGP to 8.13.0 and Kotlin to 2.2.21
example/android/app/build.gradle Lowered minSdkVersion from 26 to 24
android/src/main/kotlin/im/nfc/flutter_nfc_kit/FlutterNfcKitPlugin.kt Added handler thread lifecycle check and resurrection logic, added null-safety handling for IsoDep.historicalBytes
android/gradle/wrapper/gradle-wrapper.properties Updated Gradle wrapper to 9.2.1-bin
android/gradle.properties Increased JVM memory, updated AGP to 8.13.0 and Kotlin to 2.2.21
android/build.gradle Lowered minSdkVersion from 26 to 24
README.md Fixed typo (ISO 15963 → 15693), updated MIFARE capabilities description
CHANGELOG.md Added 3.6.1 release notes documenting all changes
.github/workflows/test.yml Added new test workflow with format checking, analysis, and pana scoring
.github/workflows/publish.yaml Updated to use actions/checkout@v6 and flutter-actions/setup-flutter@v4, removed hardcoded Flutter version
.github/workflows/example-app.yml Refactored to build both APK and iOS targets in a matrix strategy, updated to v5/v6 actions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Harry-Chen Harry-Chen requested a review from Copilot November 22, 2025 11:28
Copilot finished reviewing on behalf of Harry-Chen November 22, 2025 11:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Harry-Chen Harry-Chen requested a review from Copilot November 22, 2025 11:48
Copilot finished reviewing on behalf of Harry-Chen November 22, 2025 11:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Harry-Chen Harry-Chen requested a review from Copilot November 22, 2025 12:05
Copilot finished reviewing on behalf of Harry-Chen November 22, 2025 12:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Harry-Chen Harry-Chen requested a review from Copilot November 22, 2025 12:14
Copilot finished reviewing on behalf of Harry-Chen November 22, 2025 12:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Harry-Chen Harry-Chen merged commit fd35f4d into master Nov 22, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants