Various small bugfixes #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freymaurer
approved these changes
Jul 22, 2025
| | Some name, _ when name.Contains "_" -> | ||
| let lastUnderScoreIndex = name.LastIndexOf '_' | ||
| name.Remove lastUnderScoreIndex | ||
| //| Some name, _ when name.Contains "_" -> |
There was a problem hiding this comment.
maybe a comment why and a reference to the related issue?
| @@ -78,7 +78,7 @@ let tests_gitContracts = testList "gitContracts" [ | |||
| testCase "init_basic" <| fun _ -> | |||
| let arc = ARC("MyARC") | |||
| let contracts = arc.GetGitInitContracts() | |||
| Expect.equal contracts.Length 2 "Should be two contracts" | |||
| Expect.equal contracts.Length 1 "Should be two contracts" | |||
There was a problem hiding this comment.
"Should be two contracts"
must be updated
| @@ -113,19 +113,31 @@ let tests_gitContracts = testList "gitContracts" [ | |||
| let arc = ARC("MyARC") | |||
| let remote = @"www.fantasyGit.net/MyAccount/MyRepo" | |||
| let contracts = arc.GetGitInitContracts(repositoryAddress = remote) | |||
| Expect.equal contracts.Length 3 "Should be three contracts" | |||
| let dto = Expect.wantSome contracts.[2].DTO "Should have a DTO" | |||
| Expect.equal contracts.Length 2 "Should be three contracts" | |||
There was a problem hiding this comment.
contracts.Length 2 "Should be three contracts"
There was a problem hiding this comment.
this issue arises in multiple cases
| @@ -534,6 +533,35 @@ let private tests_ArcTablesProcessSeq = | |||
| Expect.arcTableEqual resultTables.Tables.[0] expectedTables.[0] "Table 1 should be equal" | |||
| Expect.arcTableEqual resultTables.Tables.[1] expectedTables.[1] "Table 2 should be equal" | |||
| ) | |||
| testCase "TableNameUndescore" (fun () -> | |||
There was a problem hiding this comment.
love that you added issue references to the other tests, here you missed it!
|
Thanks for your nitpicks, @Freymaurer. I made the changes accordingly and will merge now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various small bugfixes
closes #512
closes #515
closes #534
closes #538