Skip to content

Mage 1517 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Mage 1517 #93

merged 1 commit into from
Jul 21, 2025

Conversation

nruss11-om
Copy link
Contributor

  1. Convert login page from XML to Compose
  2. Refactor LoginViewModel logic and convert LiveData to Flows to support landscape mode for login page
  3. Refactor supported login types logic retrieved from server

1) Convert login page from XML to Compose
2) Refactor LoginViewModel logic and convert LiveData to Flows to support landscape mode for login page
3) Refactor supported login types logic retrieved from server
Copy link

@paulsolt-ofsw paulsolt-ofsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Tested it on a real device and in the Android Studio emulator.

@nruss11-om nruss11-om merged commit 61c727b into develop Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants