Open
Conversation
jmckomni
requested changes
Feb 12, 2026
Contributor
jmckomni
left a comment
There was a problem hiding this comment.
Can't merge until file types are not restricted
added 8 commits
February 19, 2026 06:55
…attachments, configure node debugger, etc..
…canned and cleanly running thru clamav with no errors..
…ood and bad attachments..
… and code clean-up..
7b41084 to
86a27dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary – Pre-Disk Attachment Scan
Overview
This PR implements pre-disk virus scanning for attachments using ClamAV. Attachments are validated by type (image, video, audio) and scanned before saving to the database. EICAR test files were used to verify that malicious files are correctly blocked, and valid attachments are successfully saved. Of Note: this gitlab ticket (
1752) is one of 6 sequential tickets for this track of work. For this ticket, the implementation and wiring up of the Pix/ClamAv server was done and some real-world attachment processing and testing. There are no 'bells, balloons or whistles' included in this branch, this is merely a p.o.c. that the PIX clamav server exists; that we at Mage can access it and 'forward' our attachment data to it for scanning and pass/fail, and that the back-end logs reflect that success or failure (there is no front-end update: no status messages, no error messages, no success messages, no timeouts, no warnings and no multi-file attachment saves, just one-per-time) As next stories (1753, 4, 5, etc) are completed, other requirements will be addressed.Allowed MAGE System File Types
Changes
att_clam_test.Testing Instructions
Ensure you are logged into AWS
aws sso login --profile magegovStart ClamAV port forwarding
kubectl port-forward svc/clamav 3310:3310 -n clamavLaunch the app server locally
Test good file
Test malicious file
eicar.png) with the standard EICAR stringCheck logs
Expected Results