-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dampen some useless commands #601
base: mqtt_data
Are you sure you want to change the base?
Conversation
findReason in another spot
Hi @MikeBishop, I think this would be a good candidate for merging prior to Feb 1 to reduce potential API costs, but I see that the PR targets the mqtt_data branch, is that intentional & do you think it's a good time to merge? |
That was deliberate, because it builds on things contained in that branch but I wanted this to be reviewable separately. I think both are ready to merge; we can retarget this to main once #571 is in. |
This targets the two useless commands I identified in #591; if others are noted, I can add them. It's based on #571, since it needs some of the additional state that was picked up there; I'll retarget to main once that's merged.
stopAskingToStartCharging
is set on the last-connected vehicle if that vehicle last reported an estimated time-to-completion of less than five minutes.It now also eliminates an additional useless command I discovered from my tesla-proxy logs: