optimize empty return

nggit · Nov 26, 2023 · c2661d6 · c2661d6
1 parent b0f8304
commit c2661d6
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/tremolo/http_server.py b/tremolo/http_server.py
@@ -232,7 +232,7 @@ async def _handle_response(self, func, options={}):
             if isinstance(data, str):
                 data = data.encode(encoding[0])
 
-            if no_content or data == b'':
+            if no_content:
                 self.response.set_header(b'Connection', b'close')
             else:
                 if self.response.http_chunked:
@@ -265,15 +265,17 @@ async def _handle_response(self, func, options={}):
                 if not isinstance(options, dict):
                     return
 
-            if data == b'' or self.request.method == b'HEAD' or no_content:
+            if self.request.method == b'HEAD' or no_content:
                 await self.response.write(None)
                 return
 
-            self.set_watermarks(high=options['buffer_size'] * 4,
-                                low=options['buffer_size'] // 2)
-            await self.response.write(data,
-                                      rate=options['rate'],
-                                      buffer_size=options['buffer_size'])
+            if data != b'':
+                self.set_watermarks(high=options['buffer_size'] * 4,
+                                    low=options['buffer_size'] // 2)
+                await self.response.write(data,
+                                          rate=options['rate'],
+                                          buffer_size=options['buffer_size'])
+
             await self.response.write(b'', throttle=False)
 
         self.response.close(keepalive=True)