improve CBV to allow class instance

[nggit]

Currently, HelloView.__init__() is called per-request. This makes each class instances belong to each requests, and therefore is safe by default.

class HelloView:
    async def get(self, request, **server):
        return 'Hello, World!'


app.add_route(HelloView, '/hello')
app.add_route(HelloView(), '/world')  # doesn't work

But some people may have a certain requirement or want to only call HelloView.__init__() once on main.

This little change will make this possible. No configuration, no extra flags... like init_every_request = False. Just pass a class instance!

Example

class HelloView:
    def __init__(self, event, *args, **kwargs):
        print('--> calling __init__ on:', event)

    async def get(self, request, **server):
        return 'Hello, World!'


app.add_route(HelloView, '/hello', event='request')
app.add_route(HelloView('main'), '/world')

Note

• A class with def __call__ is intentionally not supported to avoid complexity
• **server is required

Bonus

module-based is likely to work. But this should be treated as a side effect, not feature.

# mymodules/mymodule.py
async def get(request, **server):  # no 'self' here. if you insist, 'self' points to this module
    return 'Hello, World!'

from mymodules import mymodule

app.add_route(mymodule, '/foo')

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
86.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud