Allow context to be used like a dict.

[gnat]

Allows context to optionally be used like a dict.

Nice because it exposes safe get() and makes the context syntax less opinionated.

Similar issue in Starlette: encode/starlette#2389

[nggit]

That's a good idea to use a safe get().

BTW, the reason I used to create an opinionated set() function in dict is to be able to overwrite reserved properties like options and tasks consciously.

1. maybe if __setitem__ is needed, it needs to raise ValueError, if it tries to overwrite reserved properties? then a slight modification in __setitem__ is needed.

2. is __delitem__ really necessary? I always thought it is enough to set the member to None, instead of having to add the "don't delete reserved properties" logic as point 1.

[gnat]

1. Agreed
2. Agreed

Great suggestions. Updated the PR.

[nggit]

I got an idea, maybe it's simpler with just a line of setattr:

    def __setitem__(self, *args):
        self.__setattr__(*args)

This will naturally raise an AttributeError if the user tries to overwrite the readonly property of either options or tasks. What do you think, @gnat?

[gnat]

Seems fine to me; tested it with a few different patterns and it didn't cause any issues. Updated!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40d9241) 92.34% compared to head (4503058) 92.32%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   92.34%   92.32%   -0.03%     
==========================================
  Files          19       19              
  Lines        1869     1875       +6     
==========================================
+ Hits         1726     1731       +5     
- Misses        143      144       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nggit]

Thanks!

[gnat]

Nice one.