ci: run tests on multiple go versions and oses #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buchdag
force-pushed
the
multi-os-arch-tests
branch
3 times, most recently
from
b4d1780 to
f07b654
Compare
buchdag
force-pushed
the
multi-os-arch-tests
branch
from
e4d2cdd to
95811fc
Compare
buchdag
force-pushed
the
multi-os-arch-tests
branch
2 times, most recently
from
b20004c to
1b1aa82
Compare
buchdag
changed the title
buchdag
force-pushed
the
multi-os-arch-tests
branch
2 times, most recently
from
359b188 to
f0ccc41
Compare
buchdag
force-pushed
the
multi-os-arch-tests
branch
from
95be415 to
82739b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intent was initially to run the tests on multiples OSes and Go versions.
Turns out that the way docker-gen created a new temp file, wrote the rendered template to it, then used
os.Rename()to replace the old file with the temp file does not seem to work as well on Windows as it does on Linux.Since I could not find any justification as to why things where done this way other than the fact that docker-gen was released before
os.WriteFile()was available, and since this way of doing things appears to cause issues in some cases ( #15 (comment), #317 and #629), I've decided to write the rendered template content straight to the destination file instead.This simplifies the code quite a bit and should fix #629