Skip to content

TransportServer SNI #6494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

TransportServer SNI #6494

wants to merge 17 commits into from

Conversation

j1m-ryan
Copy link

Proposed changes

TransportServer SNI POC + example

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart labels Sep 24, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 91.91919% with 8 lines in your changes missing coverage. Please review.

Project coverage is 53.27%. Comparing base (62642a5) to head (2fb8fdf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...g/apis/configuration/validation/transportserver.go 80.76% 3 Missing and 2 partials ⚠️
internal/k8s/configuration.go 95.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6494      +/-   ##
==========================================
- Coverage   53.28%   53.27%   -0.02%     
==========================================
  Files          87       87              
  Lines       16255    16305      +50     
==========================================
+ Hits         8661     8686      +25     
- Misses       7181     7201      +20     
- Partials      413      418       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the helm_chart Pull requests that update the Helm Chart label Sep 25, 2024
@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels Sep 25, 2024
@j1m-ryan j1m-ryan changed the title [POC] TransportServer SNI TransportServer SNI Oct 7, 2024
@j1m-ryan j1m-ryan closed this Oct 7, 2024
@j1m-ryan j1m-ryan deleted the poc/transport-server-sni branch October 7, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant