Skip to content

Separate control plane and data plane; support multiple Gateways #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
May 15, 2025

Remove unused service annotations (#3362)

a66267b
Select commit
Loading
Failed to load commit list.
Merged

Separate control plane and data plane; support multiple Gateways #3318

Remove unused service annotations (#3362)
a66267b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 14, 2025 in 0s

86.73% (+0.52%) compared to 7bce264

View this Pull Request on Codecov

86.73% (+0.52%) compared to 7bce264

Details

Codecov Report

Attention: Patch coverage is 74.13074% with 372 lines in your changes missing coverage. Please review.

Project coverage is 86.73%. Comparing base (7bce264) to head (a66267b).

Files with missing lines Patch % Lines
internal/mode/static/manager.go 3.73% 103 Missing ⚠️
internal/mode/static/nginx/agent/command.go 81.11% 57 Missing and 11 partials ⚠️
cmd/gateway/commands.go 71.73% 50 Missing and 2 partials ⚠️
internal/mode/static/handler.go 77.01% 32 Missing and 8 partials ⚠️
cmd/gateway/certs.go 75.67% 25 Missing and 11 partials ⚠️
internal/framework/controller/predicate/secret.go 56.75% 12 Missing and 4 partials ⚠️
internal/framework/file/file.go 77.58% 12 Missing and 1 partial ⚠️
internal/mode/static/nginx/agent/action.go 83.33% 8 Missing and 2 partials ⚠️
internal/framework/controller/resource.go 0.00% 7 Missing ⚠️
...ernal/framework/controller/predicate/annotation.go 76.00% 4 Missing and 2 partials ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3318      +/-   ##
==========================================
+ Coverage   86.20%   86.73%   +0.52%     
==========================================
  Files         116      129      +13     
  Lines       11928    14862    +2934     
  Branches       62       62              
==========================================
+ Hits        10283    12891    +2608     
- Misses       1580     1822     +242     
- Partials       65      149      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.