-
Notifications
You must be signed in to change notification settings - Fork 118
Support configurable hostPort in helm chart #3321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gasoid
wants to merge
7
commits into
nginx:main
Choose a base branch
from
Gasoid:feat/hostPort
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5d59c04
feat: hostPort configurable
Gasoid 6dcba57
Merge branch 'main' into feat/hostPort
Gasoid b956397
Merge branch 'main' of github.com:nginx/nginx-gateway-fabric into fea…
Gasoid 1f7f09a
Merge branch 'main' of github.com:nginx/nginx-gateway-fabric into fea…
Gasoid 185ced7
feat: hostPort for agent-grpc configurable
Gasoid 40f2b70
feat: helm schema
Gasoid bbf9a67
feat: helm config
Gasoid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deployment is no longer for nginx, it's just the control plane.
The nginx deployment is built in-code by the control plane. #3319 is an example of how we now add a new field to the nginx deployment/service, so you'll need to do something similar to add these new hostPort fields. The fields need to exist in the NginxProxy CRD, which is populated at installation time via the helm chart (or at runtime via the k8s API), and is then ingested by the control plane to configure and deploy the nginx deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i will adjust nginxProxy CRD in order to support this hostPort field