Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cd .. before rm -rf #49

Merged
merged 2 commits into from
Apr 25, 2024
Merged

cd .. before rm -rf #49

merged 2 commits into from
Apr 25, 2024
+1 −1

Conversation

mmacdermaidsap
Copy link
Contributor

The folder and the .tar.gz don't get deleted properly when building the container because you are inside of the openssl folder via

cd openssl-${OPENSSL_VERSION}

Doing a

cd ..

Fixes this issue for the cleanup.

pdabelf5
pdabelf5 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@pdabelf5 pdabelf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmacdermaidsap for contributing

@pdabelf5 pdabelf5 merged commit 3019d15 into nginxinc:main Apr 25, 2024
3 checks passed
@mmacdermaidsap
Copy link
Contributor Author

@pdabelf5 np! Glad to help.

@lucacome lucacome added the chore label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmacdermaidsap @pdabelf5 @lucacome