Make http types directives analysable#102
Closed
chrisnovakovic wants to merge 2 commits intonginxinc:masterfrom
Closed
Make http types directives analysable#102chrisnovakovic wants to merge 2 commits intonginxinc:masterfrom
http types directives analysable#102chrisnovakovic wants to merge 2 commits intonginxinc:masterfrom
Conversation
The syntax of `http` `types` blocks is distinct, in that their child directives are arbitrary MIME types - they therefore can't be analysed when `strict` or `check_ctx` are enabled, and no meaningful analysis can be performed when `check_args` is enabled because the arity of child directives is unknown. Skip the checks performed when `strict` and `check_ctx` are enabled, and hint to the analyser that all directives inside a `types` block accept one or more arguments so that a meaningful check can be performed when `check_args` is enabled. Fixes nginxinc#101.
Author
|
I've just realised that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The syntax of
httptypesblocks is distinct, in that their child directives are arbitrary MIME types - they therefore can't be analysed whenstrictorcheck_ctxare enabled, and no meaningful analysis can be performed whencheck_argsis enabled because the arity of child directives is unknown. Skip the checks performed whenstrictandcheck_ctxare enabled, and hint to the analyser that all directives inside atypesblock accept one or more arguments so that a meaningful check can be performed whencheck_argsis enabled.Fixes #101.
Checklist